Changes for Verrazzano #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
ddsharpe commented Aug 21, 2020
ddsharpe commented - added new target type, wko
- added execute permissions to generated shell script from vz target
- corrected weblogic credential secret name for models targeted to WebLogic Operator
- changed generated Verrazzano binding defaults for DNS name to "*"
- changed generated Verrazzano binding namepace from default to {domainUid}-ns
- corrected log folder name from jcslcm-logs to wdt-logs
* added execute permissions to generated shell script from vz target * corrected weblogic credential secret name for models targeted to WebLogic Operator * changed generated Verrazzano binding defaults for DNS name to "*" * changed generated Verrazzano binding namepace from default to {domainUid}-ns * corrected log folder name from jcslcm-logs to wdt-logs 
rakillen approved these changes Aug 21, 2020
rakillen requested changes Aug 22, 2020
| admin_token = admin_lower_token[5:] | ||
| return get_secret_model_token(WEBLOGIC_CREDENTIALS_SECRET_NAME, admin_token) | ||
| secret_name = target_config.get_wls_credentials_name() or WEBLOGIC_CREDENTIALS_SECRET_NAME | ||
| return '@@SECRET:%s:%s@@' % (secret_name, admin_token) |
Member
There was a problem hiding this comment.
If target_config.get_wls_credentials_name() returns None, the secret token will be
@@SECRET:weblogic-credentials:password@@ instead of
@@SECRET:@@ENV:DOMAIN_UID@@-weblogic-credentials:password@@
which won't match the secrets script.
rakillen approved these changes Aug 24, 2020
jshum2479 reviewed Aug 24, 2020
| config[CONFIG.WLS_CREDENTIALS_NAME] = '__weblogic-credentials__' | ||
| self.target_with_cred_name = TargetConfiguration(config) | ||
| | ||
| config = dict() |
Member Author
There was a problem hiding this comment.
two different configs. changed the temporary variable names to avoid any sharing between classes during the test.
jshum2479 approved these changes Aug 24, 2020
CarolynRountree approved these changes Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.