Jira#wdt 418 encrypt multiple models #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rakillen approved these changes Jun 11, 2020
Member
| Please improve description of this change. Its not clear what you are trying to accomplish with this PR. |
rakillen reviewed Jun 11, 2020
| ECHO model_file - the location and name of the model file to use, or | ||
| ECHO the locations and names of each model in a set of | ||
| ECHO models. All models will be written back to the same | ||
| ECHO location and name. |
Member
There was a problem hiding this comment.
Maybe clarify that comma-separated list for multiples? other tools say "the location of the model file to use. This can also be specified as a comma-separated list of model locations, ..."
rakillen reviewed Jun 11, 2020
| echo " model_file - the location and name of the model file or the" | ||
| echo " locations and names of each model in a set of" | ||
| echo " models. All models will be written back to the same" | ||
| echo " location and name." |
ddsharpe approved these changes Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changed to Take a single or multiple models into the Encrypt tool. The passwords in each model are encrypted and each model written out to the original location. The single variable file is shared by the set of models, and the password variables encrypted only once.
Encryption tool did already have checks not to encrypt and encrypted password. I changed the variables code to do a check identical to model code.
Fixes #547