Wdt 412 #616

jshum2479 · 2020-04-27T14:49:26Z

This restore the return code of restart required if wlst isRestartRequired returns true during update operation.

rakillen · 2020-04-27T15:05:10Z

core/src/main/python/wlsdeploy/util/cla_utils.py

 ARG_VALIDATION_ERROR_EXIT_CODE = 98
 PROG_RESTART_REQUIRED = 103
- PROG_ROLLBACK_IF_RESTART_EXIT_CODE = 3
+ PROG_ROLLBACK_IF_RESTART_EXIT_CODE = 104


Needs a message in shared.sh, shared.cmd in checkExitCode for this exit code

core/src/main/python/update.py

CarolynRountree · 2020-04-27T17:52:21Z

core/src/main/python/wlsdeploy/util/cla_utils.py

 ARG_VALIDATION_ERROR_EXIT_CODE = 98
 PROG_RESTART_REQUIRED = 103
- PROG_ROLLBACK_IF_RESTART_EXIT_CODE = 3
+ PROG_ROLLBACK_IF_RESTART_EXIT_CODE = 104


Just read the update document trying to find the command line argument to rollback. That argument isn't documented and also there are bad RCs in the documentation that need to be removed. 104 needs to be added.

101 - The domain needs to be restarted and the Update Domain Tool needs to be re-invoked with the same arguments. 102 - The servers impacted by the update operation need to be restarted, in a rolling fashion, starting with the Administration Server, if applicable. 103 - The entire domain needs to be restarted.

CarolynRountree

I created a simple JRF domain. Then ran update with a value that requires restart. I got a failure with the update that edit was in progress, even though I just created the domain in the previous step.

SEVERE Messages: 1. WLSDPLY-09015: updateDomain deployment failed: Domain has outstanding edit session weblogic, deploy cannot proceed and will exit Total: WARNING : 0 SEVERE : 1 updateDomain.cmd failed (exit code = 2)

I tried it again with a brand new domain as I had been using the same name for several tests the last few days. This time I got

Problem invoking WLST - Traceback (innermost last): File "C:\Users\crountre\temp\weblogic-deploy\lib\python\update.py", line 328, in ? File "C:\Users\crountre\temp\weblogic-deploy\lib\python\update.py", line 313, in main File "C:\Users\crountre\temp\weblogic-deploy\lib\python\update.py", line 106, in __update File "C:\Users\crountre\temp\weblogic-deploy\lib\python\update.py", line 149, in __update_online File "C:\Users\crountre\temp\weblogic-deploy\lib\python\update.py", line 180, in __check_update_require_domain_restart File "C:\Users\crountre\temp\weblogic-deploy\lib\python\wlsdeploy\tool\util\wlst_helper.py", line 231, in cancel_edit File "<iostream>", line 591, in cancelEdit File "<iostream>", line 553, in raiseWLSTException WLSTException: Error occurred while performing cancelEdit : Cannot call Edit functions when you are not in the Edit tree. updateDomain.cmd completed but with some issues (exit code = 1)

jshum2479 · 2020-04-27T20:26:49Z

Hmm, what's your test case looks like? and any logs?

CarolynRountree · 2020-04-27T20:37:21Z

updateDomain.log.txt
clusterslimits.yml.txt

created a domain with clusterslimit.yml and clusters.properties with following command line:

weblogic-deploy\bin\createDomain.cmd -oracle_home c:\oracle\fmw12213 -domain_home c:\oracle\fmw12213\user_projects\domains\rollback_domain -model_file .\clusterslimits.yml -variable_file .\clusters.properties -domain_type JRF -run_rcu -rcu_prefix CERJRF -rcu_db localhost:32769/ORCLPDB1.localdomain

Started admin server
Ran update domain with clustersupdate.yml and this command line

weblogic-deploy\bin\updateDomain.cmd -oracle_home c:\oracle\fmw12213 -domain_home c:\oracle\fmw12213\user_projects\domains\rollback_domain -model_file .\clustersupdate.yml -domain_type JRF -rollback_if_require_restart -admin_url t3://localhost:7001 -admin_user weblogic

clustersupdate.yml.txt

createDomain.log.txt

CarolynRountree · 2020-04-28T16:35:01Z

site/update.md

 When running the tool in WLST online mode, the update operation may require server restarts or a domain restart to pick up the changes. The update operation can also encounter situations where it cannot complete its operation until the domain is restarted. To communicate these conditions to scripts that may be calling the Update Domain Tool, the shell scripts have three special, non-zero exit codes to communicate these states:

 - `101` - The domain needs to be restarted and the Update Domain Tool needs to be re-invoked with the same arguments.
 - `102` - The servers impacted by the update operation need to be restarted, in a rolling fashion, starting with the Administration Server, if applicable.


the rollback command arg is not documented. And the 101, 102 are not valid are they?

The rollback command arg is for future operator use only originally, let me add the doc in it. I didn't change 101 and 102, no idea where they come from

CarolynRountree · 2020-04-28T16:35:55Z

site/deploy.md


 When running the tool in WLST online mode, the deploy operation may require server restarts or a domain restart to pick up the changes. The deploy operation can also encounter situations where it cannot complete its operation until the domain is restarted. To communicate these conditions to scripts that may be calling the Deploy Applications Tool, the shell scripts have three special, non-zero exit codes to communicate these states:

 - `101` - The domain needs to be restarted and the Deploy Applications Tool needs to be re-invoked with the same arguments.


101 and 102 are not valid are they? the rollback command line arg is not documented.

I don't see anywhere returning 101, 102 from the source. I am removing them now.

jshum2479 · 2020-04-30T13:35:00Z

Added online system test also

Johnny Shum added 3 commits April 24, 2020 18:10

fix missing return code for online update after refactoring

670f392

rename function

518a33c

correct logic

8066018

jshum2479 requested review from CarolynRountree, ddsharpe and rakillen April 27, 2020 14:49

rakillen reviewed Apr 27, 2020

View reviewed changes

add return code to share.sh

dc6e401

CarolynRountree suggested changes Apr 27, 2020

View reviewed changes

core/src/main/python/update.py Show resolved Hide resolved

CarolynRountree approved these changes Apr 27, 2020

View reviewed changes

CarolynRountree suggested changes Apr 27, 2020

View reviewed changes

update documentation with new return code

2c549ba

CarolynRountree suggested changes Apr 27, 2020

View reviewed changes

jshum2479 and others added 4 commits April 27, 2020 17:42

correct side effect after calling setServerGroups

7827ccc

spelling

05f3fa0

update comments

195ab10

add comment

4f0a81f

CarolynRountree suggested changes Apr 28, 2020

View reviewed changes

Johnny Shum added 2 commits April 28, 2020 14:05

add doc and update script

de281d4

remove 101, 102 return code, no where is returning it

3a81f04

CarolynRountree approved these changes Apr 28, 2020

View reviewed changes

Johnny Shum added 4 commits April 29, 2020 19:15

Add online system tests

2ca98e0

Merge branch 'master' into WDT-412

c57259e

remove unused test and increase start server time

bee9ac6

Remove fake network channel

952f54e

minor cleanup

3b5505b

ddsharpe approved these changes Apr 30, 2020

View reviewed changes

rakillen approved these changes Apr 30, 2020

View reviewed changes

ddsharpe merged commit 97d8ff1 into master Apr 30, 2020

ddsharpe deleted the WDT-412 branch April 30, 2020 18:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wdt 412 #616

Wdt 412 #616

Uh oh!

jshum2479 commented Apr 27, 2020

rakillen Apr 27, 2020

jshum2479 Apr 27, 2020

Uh oh!

CarolynRountree Apr 27, 2020

jshum2479 Apr 27, 2020

CarolynRountree left a comment •

edited

Loading

jshum2479 commented Apr 27, 2020

CarolynRountree commented Apr 27, 2020 •

edited

Loading

CarolynRountree Apr 28, 2020

jshum2479 Apr 28, 2020

CarolynRountree Apr 28, 2020

jshum2479 Apr 28, 2020

jshum2479 commented Apr 30, 2020

Labels

4 participants


		When running the tool in WLST online mode, the deploy operation may require server restarts or a domain restart to pick up the changes. The deploy operation can also encounter situations where it cannot complete its operation until the domain is restarted. To communicate these conditions to scripts that may be calling the Deploy Applications Tool, the shell scripts have three special, non-zero exit codes to communicate these states:

		- `101` - The domain needs to be restarted and the Deploy Applications Tool needs to be re-invoked with the same arguments.

Wdt 412 #616

Wdt 412 #616

Uh oh!

Conversation

jshum2479 commented Apr 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CarolynRountree left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

jshum2479 commented Apr 27, 2020

CarolynRountree commented Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jshum2479 commented Apr 30, 2020

Labels

4 participants

CarolynRountree left a comment •

edited

Loading

CarolynRountree commented Apr 27, 2020 •

edited

Loading