Configure ODL using WDT model #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
rakillen commented Nov 8, 2019
rakillen commented - offline only
- configuration is done after updateDomain, when logging configurations are created
- created ODLConfiguration alias file to simplify validation and print-usage
- refactored __model_categories_map in alias_entries.py
…e and print-usage
| Just a general comment, and not a review comment. It would be nice to allow a user to have their own modelso that products like SOA can include special processing and also attributes that are loaded when their product jars are loaded (i.e. set (cmo.setFoo where foo is a custom attribute loaded from SOA))) |
CarolynRountree previously approved these changes Nov 12, 2019
ddsharpe previously approved these changes Nov 12, 2019
rakillen dismissed stale reviews from ddsharpe and CarolynRountree via 7dca91f ddsharpe previously approved these changes Nov 12, 2019
ddsharpe previously approved these changes Nov 12, 2019
CarolynRountree previously approved these changes Nov 12, 2019
rakillen dismissed stale reviews from CarolynRountree and ddsharpe via 254fe60 
CarolynRountree approved these changes Nov 13, 2019
ddsharpe approved these changes Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.