Extractdiffloc #414
Merged
Extractdiffloc #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ers, scripts, nodeManager goes to domain home during extraction
# Conflicts: # core/src/main/python/wlsdeploy/aliases/alias_entries.py
Contributor
CarolynRountree left a comment
CarolynRountree left a comment There was a problem hiding this comment.
Since it is so specific to image tool and operator, what about making it an environment variable instead?
Member Author
| I changed to use environment variable STORE_MODEL instead |
ddsharpe previously approved these changes Aug 13, 2019
rakillen reviewed Aug 13, 2019
| self.library_helper.install_domain_libraries() | ||
| self.library_helper.extract_classpath_libraries() | ||
| self.wlsroles_helper.process_roles() | ||
| if os.environ.has_key('__STORE_MODEL__'): |
Member
There was a problem hiding this comment.
Any interest in changing this to "__WLSDEPLOY_STORE_MODEL__"? They do this elsewhere in the code, such as WLSDeployLoggingConfig.java . I could live with either, though
rakillen approved these changes Aug 13, 2019
ddsharpe approved these changes Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I want to add a flag -store_model <1> to the WDT. If the argument -store_model 1 is passed for createDomain, the merged model is stored in the $domain/wlsdeploy/domain_saved.json - a fixed location. This is only used by the operator temporarily during introspect job.