Issue #359 - Support custom extension templates #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
CarolynRountree suggested changes Apr 23, 2019
Contributor
There was a problem hiding this comment.
You should not bypass the setServerGroups if there are any groups in serverGroupsToTarget. If there is a server group in the custom template, document that it must be added to the serverGroupsToTarget?
What kind of testing did you do? I think there is some sort of default targeting to a cluster, but what if it has server groups? Also what if the domain has multiple clusters and stand-alone servers? Were the resources in the config.xml targeted correctly?
Did you test it with both extension templates and not extension templates? Online and offline?
10.3.6 and whenever the new template verb started?
CarolynRountree approved these changes Apr 25, 2019
ddsharpe approved these changes Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added customExtensionTemplates property to typedefs.
For 12c, custom extension templates are selected using selectCustomTemplate().
For 11g, they are treated the same as extension templates.
Fix to update the domain after adding templates for 11g non-JRF.
Fixes #359