Skip to content

Conversation

surskitt
Copy link

@surskitt surskitt commented Mar 6, 2019

After attempting to use the tool on solaris 11, we've noticed the included awk does not allow spaces between the "-F" option and its argument.

Copy link
Member

@ddsharpe ddsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux and MacOS

Copy link
Member

@ddsharpe ddsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Contributing.md.

For pull requests to be accepted, the bottom of your commit message must have the following line using your name and e-mail address as it appears in the OCA Signatories list.

Signed-off-by: Your Name you@example.org
This can be automatically added to pull requests by committing with:

git commit --signoff

@surskitt
Copy link
Author

surskitt commented Mar 7, 2019

Thanks @ddsharpe, I've added a signoff to the commit, hopefully it can be accepted now.

Apologies for not following the contribution readme, will make sure to follow in the future.

@ddsharpe
Copy link
Member

ddsharpe commented Mar 7, 2019

Shane,
I don't see your name on the OCA list yet. https://www.oracle.com/technetwork/community/oca-486395.html. Did you submit the signed document to Oracle legal as the page described? Everything else looks good. Let me now if/when you did, and I will go track it down with the legal team.

Thanks,
Derek

@ddsharpe
Copy link
Member

@shanedonohoe are you working on the OCA approval? ETA?

@surskitt
Copy link
Author

Yes, it's currently with legal.

If it suits you better, I'm fine with this pull request being rejected and a new one being handled by a team member.

@ddsharpe
Copy link
Member

I am happy to wait. Please let me know when it gets approved. Thank you!

@ddsharpe
Copy link
Member

ddsharpe commented Apr 4, 2019

@shanedonohoe Are you waiting on Oracle at this point, or someone at your company?

@surskitt
Copy link
Author

surskitt commented Apr 4, 2019

No, someone in the company...asked for updates a few times.

@ddsharpe
Copy link
Member

ddsharpe commented May 7, 2019

@shanedonohoe any updates from your company?

@rakillen
Copy link
Member

This was incorporated into #377 for release 0.25

@ddsharpe
Copy link
Member

Due to lack of response, a similar fix was implemented in #377

@ddsharpe ddsharpe closed this May 30, 2019
@surskitt
Copy link
Author

Thanks for introducing the fix, I'm still disappointed that I wasn't able to get the approval on my end to finalise the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants