Collect jdbc wallet #1379
Collect jdbc wallet #1379
Conversation
jshum2479 requested review from CarolynRountree, ddsharpe, rakillen and robertpatrick 
oracle-contributor-agreement bot added the OCA Verified 
| <02-04-2023 00:20:04> Executing shell command: target/weblogic-deploy/bin/archiveHelper.sh add databaseWallet -source src/test/resources/cwallet.sso -wallet_name acmeWallet -archive_file target/test-output/test35DiscoverDomainWithJDBCWallet/gen-wallet-archive.zip <02-04-2023 00:20:04> Test log: target/test-output/test35DiscoverDomainWithJDBCWallet <02-04-2023 00:20:04> Executing shell command: target/weblogic-deploy/bin/createDomain.sh -oracle_home /u01/oracle -domain_home ./target/domains/domain2-discover35 -model_file src/test/resources/simple-topology-jdbcwallet.yaml -archive_file target/test-output/test35DiscoverDomainWithJDBCWallet/gen-wallet-archive.zip <02-04-2023 00:20:15> ========== FAILED test [Test 35: test create and discover domain with jdbc wallet] method=test35DiscoverDomainWithJDBCWallet: 0 min, 11 sec ========== |
| for entry in archive_entries: | ||
| if entry.startswith(WLSDeployArchive.ARCHIVE_DB_WALLETS_DIR): | ||
| if os.path.isdir(entry): | ||
| name = wallet_names.add(os.path.basename(entry)) |
There was a problem hiding this comment.
Set().add() does not return anything, so name will be void for this code path. I don't think that is what you intended.
There was a problem hiding this comment.
That's unintentional, fixed
core/src/main/python/wlsdeploy/tool/discover/common_resources_discoverer.py Outdated Show resolved Hide resolved
| Kudos, SonarCloud Quality Gate passed! |
5 participants
The PR collects the wallet of the data source if the connection property is pointing to a directory or file in the archive during discovery