Aliastest clear password #1243
Closed
Aliastest clear password #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oracle-contributor-agreement bot added the OCA Verified 
robertpatrick requested changes Nov 4, 2022
| return generator_utils.sort_dict(attribute_map) | ||
| | ||
| def create_security_type(self, mbean_type): | ||
| _method_name = 'create_security_type' |
There was a problem hiding this comment.
Do not delete my logging statements.
| mbean_instance = generator_wlst.create_security_provider(mbean_name, provider_sub_type, | ||
| singular_mbean_type) | ||
| else: | ||
| mbean_instance = generator_wlst.get_mbean_proxy(mbean_path) |
There was a problem hiding this comment.
You are undoing my fixes...never, ever going to merge this.
| generator_wlst.cd_mbean(orig) | ||
| return True, singular_mbean_type, folder_dict | ||
| | ||
| # FIXME - This is dead code |
There was a problem hiding this comment.
I deleted all of this code because it is not being used...not adding it back
| Kudos, SonarCloud Quality Gate passed!
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Generate was removing clear text passwords