Set domain type in domain resource templates #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rakillen changed the title 
robertpatrick approved these changes May 25, 2022
| | ||
| def uses_wdt_model(self): | ||
| """ | ||
| Determine if this configuration uses a WDT model to build the domain. |
There was a problem hiding this comment.
You might want to clarify this comment. From the way that the code is written, I assume what you really mean is whether operator is using a model to build the domain (since Domain in Image is also using a model to build the domain).
ddsharpe approved these changes May 25, 2022
| Kudos, SonarCloud Quality Gate passed! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hide the spec / configuration / model section unless the domain source type is model-in-image.
Move target configuration validation to target_configuration.py .
Assign default extract target type before processing arguments.
Internal JIRA WDT-613