return result in _process_roles_map to fix role edits #1133
Conversation
looks like a previous cleanup commit removed the 'return result' line from _process_roles_map() - that prevents process_roles() from calling _update_xacml_role_mapper() with the role changes.
| Kudos, SonarCloud Quality Gate passed! |
| @DSmithVA In order for me to be able to merge your PR, please review the CONTRIBUTING.md file to sign the Contributor agreement and add a sign-off commit to your PR branch. If for some reason you cannot or do not want to do this, let us know and we can fix the issue for you. |
There was a problem hiding this comment.
This request needs to be signed. Please see https://github.com/oracle/weblogic-deploy-tooling/blob/main/CONTRIBUTING.md within this project for instructions on signing contributions. Note, the signee needs to sign the Oracle Contributor's Agreement. The OCA link is available within the CONTRIBUTING.md document.
| i'm just getting errors from docusign, so if this one-liner can be done by someone else that'd be great |
| Replaced by #1134, as requested. |
3 participants
looks like a previous cleanup commit removed the 'return result' line from _process_roles_map() - that removal prevents process_roles() from calling _update_xacml_role_mapper() with the role changes, so WLSRoles entries were not actually doing anything.