Skip to content

rename type field + ui fixes #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2013
Merged

rename type field + ui fixes #646

merged 3 commits into from
Jul 9, 2013

Conversation

@tarzanek
Copy link
Contributor

@tarzanek tarzanek commented Jul 4, 2013

fixes #634 and fixes #630
@ghost ghost assigned tarzanek Jul 4, 2013
vladak
vladak reviewed Jul 9, 2013
View reviewed changes
web/utils.js Outdated
Copy link
Member

@vladak vladak Jul 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was the code commented out ?
Copy link
Contributor Author

@tarzanek tarzanek Jul 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't really want to clear your project selection (I think there is even a bug for it, Marcel filed it long time ago)
Copy link
Contributor Author

@tarzanek tarzanek Jul 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will close bug #548 as well :)
Copy link
Member

@vladak vladak Jul 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am worried about bit rot - why not to remove the code altogether ?
@tarzanek tarzanek merged commit c221b36 into oracle:master Jul 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@tarzanek @vladak