Skip to content

Conversation

idodeclare
Copy link
Contributor

Hello,

Please consider for integration this patch as a follow-on to #2979, incorporating feedback from @vladak.

The file extension mapping redundancy in Ctags is fixed, and mappings are done based on analyzer prefixes or suffixes during registerAnalyzer(). This created a test error for an assembly language test file, bug19195/test.s, which was formerly analyzed by the CAnalyzer but implicitly tagged by the Ctags Asm parser. I cloned CAnalyzer as AsmAnalyzer, mapping .S and .ASM to it.

Thank you.

CtagsTest.bug19195() was newly failing from explicit registration of .S files for the Ctags C parser versus former implicit use of the Ctags Asm parser. With this change, OpenGrok now explicitly registers the Asm parser for .S and .ASM files.
@vladak
Copy link
Member

vladak commented Nov 29, 2019

Nice ! Paves the way for #930 I guess.

@vladak vladak merged commit 50065c9 into oracle:master Nov 29, 2019
@idodeclare
Copy link
Contributor Author

Thank you for reviewing, @vladak.

@idodeclare idodeclare deleted the feature/uctags2 branch November 29, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants