improving the color palette for annotations

[tulinkry]

fixes #1361
This is heavily inspired by annotate in idea so we get some better feel out of it.

• colours on all revisions
• most recent is yellow (see the screenshots)
• most recent is also marked with "*"

For two adjacent revisions there is a slightly different shade of the color, still not easy to perceive it very quickly, but definitely faster then as it used to be (5a and 98 are one revision apart).

[coveralls]

Pull Request Test Coverage Report for Build 4164

• 18 of 22 (81.82%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 73.614%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
opengrok-indexer/src/main/java/org/opengrok/indexer/web/Util.java	0	4	0.0%

Totals
Change from base Build 4159:	0.01%
Covered Lines:	33624
Relevant Lines:	45676

---

💛 - Coveralls

[tulinkry]

The idea uses this rainbow on the annotations:

I tried the approach and it looks like this:

Not bad. I'd still prefer the overall color palette generated with hsl, but this isn't bad. You decide. My only worry is about copyrights as this is reversed engineered from IDEA. Is that ok?

[vladak]

Foremost, I am not a lawyer. It seems to me that as long as you take just the idea it should be fine (as long as it is not patented :-D). Could you try cranking the saturation a bit ? The colors look a tad more faded than in the original rainbow design.

[tulinkry]

This is back to the rgb color space, so no saturation here. I'd need to choose different stop colours for the rainbow (by hand). These exactly match the IDEA based on color picker. (Repeating:) The image here looks little faded but when you see it on the page it is similar to what you see in IDEA and it's not bad.

[vladak]

Ok, go ahead then. I think it makes sense in this case to stick with de-facto standard color scheme rather than pushing/inventing our own.

[tulinkry]

Time to revive this

[vladak]

Will take a look. Are you done making changes ? Dne čt 20. 6. 2019 18:01 uživatel Kryštof Tulinger <notifications@github.com> napsal:

…

Time to revive this — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2733?email_source=notifications&email_token=AAWMMDDPHHCUC6Q6Y3LMD5DP3OSWLA5CNFSM4HCCLSLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYF3QOY#issuecomment-504084539>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWMMDHVELK2WVP6D2QXV3LP3OSWLANCNFSM4HCCLSLA> .

[tulinkry]

Ill fix the tests but then it’s ready

[tulinkry]

Seems like it's passing

[tulinkry]

ready

[vladak]

Okay, let's merge this and see what the feedback will be.