make it possible to mirror more projects at once #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| Another hopefully positive side effect is that configuration is now checked before the run. |
added 2 commits March 22, 2019 16:17
Pull Request Test Coverage Report for Build 4183
💛 - Coveralls |
added 12 commits March 25, 2019 14:06
make repository construction and synchronization best effort
tulinkry reviewed Apr 5, 2019
opengrok-tools/src/main/python/opengrok_tools/scm/repofactory.py Outdated Show resolved Hide resolved
Contributor
| How exactly you mirror multiple projects at one? I still see a sequential loop in there. |
Member Author
| the main loop is in for project_name in projects: if args.batch: get_batch_logger(logdir, project_name, args.loglevel, args.backupcount, get_class_basename()) project_result = mirror_project(config, project_name, args.incoming, args.uri, source_root) if project_result == 1: ret = 1it should be possible to take this one step further and make it parallelized so that it can be used outside of |
added 2 commits April 8, 2019 09:30
Contributor
| There are 11 unresolved comments and you merged it? Any plan to resolve them? |
Member Author
| I believe all of them were resolved. |
This was referenced Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
mirror.pywas always good candidate for refactoring. I used the opportunity to add the capability of mirroring multiple projects in one run. The intention is to use it in the Docker script (OpenGrok/docker#27).This change also adds
--allswitch mirrors all indexed projects. This is mutually exclusive with project arguments of the script.