Fix #1999 : REFS aren't indexed if DEFS is empty

[idodeclare]

Hello,

Please consider for integration this patch to index REFS independently from DEFS and to bump the affected analyzers' specialized version numbers.

Thank you.

[coveralls]

Pull Request Test Coverage Report for Build 3862

• 34 of 34 (100.0%) changed or added relevant lines in 31 files are covered.
• 5 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.02%) to 73.136%

---

Files with Coverage Reduction	New Missed Lines	%
opengrok-indexer/src/main/java/org/opengrok/indexer/history/FileHistoryCache.java	1	73.49%
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/AnalyzerGuru.java	2	82.99%
opengrok-indexer/src/main/java/org/opengrok/indexer/history/BazaarRepository.java	2	70.16%

Totals
Change from base Build 3858:	0.02%
Covered Lines:	32787
Relevant Lines:	44830

---

💛 - Coveralls

[tulinkry]

👍

[tulinkry]

the new line break is not necessary here I think but that's not important

[tulinkry]

Looks ok.

[idodeclare]

Thank you for the review, @tulinkry

[tarzanek]

this looks OK, however I don't know if REFS have any value without DEFS in the file (yes, you should get existing symbols in index at least, if local file has none detected)

[tarzanek]

so the question is whether this won't waste more cpu cycles than add value

[tarzanek]

that said I am OK with merge

[vladak]

Merged based on Slack #dev discussion.

[idodeclare]

this looks OK, however I don't know if REFS have any value without DEFS in the file (yes, you should get existing symbols in index at least, if local file has none detected)

@tarzanek, OpenGrok REFS are of course also useful for linking to definitions in other files.

While in e.g. Java or C it's difficult to come up with a useful, example source code file that has no DEFS from ctags, in Shell for example (and per the linked issue #1999), you can have a source code file that does useful things but which has no aliases, functions, or heredocs itself — and so has no results from ctags — but which includes another file using . and calls the included file's scripts.

Without this change, the first example file's REFS would not be indexed, so the file would not be seen as a caller of the included file's functions.