Skip to content

Conversation

@idodeclare
Copy link
Contributor

Hello,

Please consider for integration this patch to fix some highlighting bugs:

  • Fix ContextFormatter bounds problem.
  • Fix PassageConverter mistakenly counting EOL and sometimes eliding too much from the left.

IntelliJ was also helpful in suggesting some nice simplifications of the code.

Thank you.

- Fix ContextFormatter bounds problem. - Fix PassageConverter mistakenly counting EOL and sometimes eliding too much from the left. - Simplify blocks.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3624

  • 42 of 42 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 73.439%

Files with Coverage Reduction New Missed Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/search/context/PassageConverter.java 1 92.17%
Totals Coverage Status
Change from base Build 3623: 0.04%
Covered Lines: 32845
Relevant Lines: 44724

💛 - Coveralls
@tarzanek tarzanek added this to the 1.1 milestone Nov 26, 2018
@tarzanek tarzanek self-assigned this Nov 26, 2018
@tarzanek
Copy link
Contributor

merging, thank you Chris!

@tarzanek tarzanek merged commit 5c793da into oracle:master Nov 26, 2018
@idodeclare idodeclare deleted the bugfix/highlighting branch November 28, 2018 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants