Skip to content

Conversation

@tarzanek
Copy link
Contributor

@tarzanek tarzanek commented Oct 25, 2018

this is a good start, next steps are sanitize C:\ or any other letter and strip them
and make sure whole app just uses "/" and on windows all input or output gets properly sanitized and stripped if needed

@coveralls
Copy link

coveralls commented Oct 25, 2018

Pull Request Test Coverage Report for Build 3483

  • 27 of 32 (84.38%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 73.499%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/web/Util.java 13 14 92.86%
opengrok-indexer/src/main/java/org/opengrok/indexer/web/PageConfig.java 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/history/HistoryGuru.java 2 66.94%
opengrok-indexer/src/main/java/org/opengrok/indexer/history/BazaarRepository.java 2 70.16%
Totals Coverage Status
Change from base Build 3476: 0.001%
Covered Lines: 32105
Relevant Lines: 43681

💛 - Coveralls
@tarzanek
Copy link
Contributor Author

need to backout the executable changes in tools/pom.xml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not lead to the local build and installs the package to the global scope

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional rule?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first letter should be lowercase

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or if its constant, it should be final and all upper case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure that there will be no npe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some reformat would help here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property should be on top of the class

Copy link
Contributor

@tulinkry tulinkry Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if user has the data on D: ?

@tarzanek
Copy link
Contributor Author

tarzanek commented Nov 6, 2018

so besides addressing the data on d: these changes should work, let's see about tests

@tarzanek tarzanek self-assigned this Nov 6, 2018
@tarzanek tarzanek added this to the 1.1 milestone Nov 6, 2018
@tarzanek tarzanek merged commit 7421b47 into oracle:master Nov 6, 2018
@tarzanek tarzanek deleted the OpenGrok-2359 branch November 6, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants