- Notifications
You must be signed in to change notification settings - Fork 791
sanitize more paths on windows, fixes #2335 #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 3483
💛 - Coveralls |
| need to backout the executable changes in tools/pom.xml |
opengrok-tools/pom.xml Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not lead to the local build and installs the package to the global scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditional rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the first letter should be lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or if its constant, it should be final and all upper case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you sure that there will be no npe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some reformat would help here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
property should be on top of the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if user has the data on D: ?
4f8209e to 8f00ca4 Compare | so besides addressing the data on d: these changes should work, let's see about tests |
8f00ca4 to 23aa741 Compare 23aa741 to 807ead8 Compare
this is a good start, next steps are sanitize C:\ or any other letter and strip them
and make sure whole app just uses "/" and on windows all input or output gets properly sanitized and stripped if needed