Fix #2118 : limit CtagsReader lookahead for pathologically-long lines #2125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… lines Background: Universal ctags extracts tags from pathologically-long lines but only shows the pattern from the initial part of the line. OpenGrok will now only try to find heuristically the position of tags beyond the initial pattern up to a limit of 2,000 characters. Also, a tiny cache is used to speed sequential tags from the same line.
Pull Request Test Coverage Report for Build 2487
💛 - Coveralls |
Contributor
| merging, thank you |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this patch to fix issue #2118.
Background: Universal ctags extracts tags from pathologically-long lines but only shows the pattern from the initial part of the line.
OpenGrok will now only try to find heuristically the position of tags beyond the initial pattern
up to a limit of 2,000 characters.
Also, a tiny cache is used to speed sequential tags from the same line.