Skip to content

Conversation

@idodeclare
Copy link
Contributor

Hello,

Please consider for integration this tiny patch to fix CVSRepositoryTest to use CVSRepository getRepoCommand(), so that the test uses a developer's environment override of cvs command.

Thank you.

@tarzanek
Copy link
Contributor

tarzanek commented Jan 6, 2018

weird, I thought repo init will init the SCM command from -d variables ...
(but perhaps cvs needs a fix in this regard)

I can merge this(didn't look at how we do it for other repos and whether the logic to isolate overrides from within repos works well for all SCM providers), so I hope my trust here is OK and you did verify the others ;)

I know that for e.g. git or hg this override works well (since I override them on windows dev env with -d to fit custom binaries on windows)

@tarzanek tarzanek self-assigned this Jan 6, 2018
@tarzanek tarzanek added this to the 1.1 milestone Jan 6, 2018
@tarzanek
Copy link
Contributor

tarzanek commented Jan 6, 2018

merging, let's see if I am wrong or not :)

@tarzanek tarzanek merged commit 02d64d9 into oracle:master Jan 6, 2018
@idodeclare idodeclare deleted the bugfix/cvs_cmd branch January 6, 2018 12:45
@idodeclare
Copy link
Contributor Author

Yes it was just this test that was running a non-overridden command. Thank you, Lubos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants