Skip to content

ODSC 39392/triton #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 25, 2023
Merged

ODSC 39392/triton #128

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e40302d
commit the code for triton
Mar 29, 2023
e242369
remove the blank
Mar 29, 2023
072a048
ODSC-39392: fix the code based on the comments
Apr 10, 2023
429d4ea
add implementation for predict
Apr 10, 2023
350f0ea
adding unit test
Apr 10, 2023
5985af2
Merge branch 'develop' into ODSC-39392/triton
Apr 10, 2023
190509b
fix unit test
Apr 10, 2023
35fe0d2
Merge branch 'ODSC-39392/triton' of github.com:oracle/accelerated-dat…
Apr 10, 2023
2f0758f
ODSC-39392: resolve the comments
Apr 12, 2023
3c32175
fix based on the comment
Apr 17, 2023
708ce2f
Merge branch 'develop' of github.com:oracle/accelerated-data-science …
Apr 17, 2023
9fdb1ff
ODSC-39392: fix the test
Apr 24, 2023
b66c02f
Merge branch 'develop' into ODSC-39392/triton
Apr 24, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ODSC-39392: fix the test
  • Loading branch information
Ziqun Ye committed Apr 24, 2023
commit 9fdb1ffb7cf0d5bb01ab919fbc537a7f5592cf43
2 changes: 1 addition & 1 deletion ads/model/deployment/common/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,14 @@ def send_request(

request_kwargs["headers"] = header

request_kwargs["auth"] = header.pop("signer")
if dry_run:
request_kwargs["headers"]["Accept"] = "*/*"
req = requests.Request("POST", endpoint, **request_kwargs).prepare()
if is_json_payload:
return json.loads(req.body)
return req.body
else:
request_kwargs["auth"] = header.pop("signer")
Copy link
Member

@qiuosier qiuosier Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we pop signer for dry_run as well?
Copy link
Author

@z7ye z7ye Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
return requests.post(endpoint, **request_kwargs).json()


Expand Down