Updates demo dependencies. Minor code tweaks #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Jones <christopher.jones@oracle.com>
dmcghan approved these changes Feb 4, 2021
Comment on lines +4 to +9
| // Tell node-oracledb where to find the Oracle Instant Client 'Basic' package on macOS and Windows | ||
| if (process.platform === 'darwin') { | ||
| oracledb.initOracleClient({libDir: process.env.HOME + '/Downloads/instantclient_19_8'}); | ||
| } else if (process.platform === 'win32') { | ||
| oracledb.initOracleClient({libDir: 'C:\\oracle\\instantclient_19_8'}); // note the double backslashes | ||
| } // else you must set the system library search path before starting Node.js |
Comment on lines +29 to +44
| try { | ||
| conn = await oracledb.getConnection(); | ||
| result = await conn.execute(statement, binds, opts); | ||
| return (result); | ||
| } catch (err) { | ||
| console.error(err); | ||
| throw (err); | ||
| } finally { | ||
| if (conn) { // conn assignment worked, need to close | ||
| try { | ||
| await conn.close(); | ||
| } catch (err) { | ||
| console.error(err); | ||
| } | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
I like this better than using an explicit promise.
| "oracledb": "^3.1.2" | ||
| "express": "^4.17.1", | ||
| "morgan": "^1.10.0", | ||
| "oracledb": "^5.1.0" |
anthony-tuininga approved these changes Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher Jones christopher.jones@oracle.com