add api-level tests with a few bug fixes #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
jaeopt commented Mar 11, 2019
jaeopt commented - fix to return false if "featureEnabled" field is missing
- add more info OptimizelyError to return correct error types
- add "API" test folders
- refactor test folders as discussed (a shared info.plist) and remove -iOS/-tvOS appending
thomaszurkan-optimizely approved these changes Mar 12, 2019
Contributor
thomaszurkan-optimizely left a comment
thomaszurkan-optimizely left a comment There was a problem hiding this comment.
LGTM. I had one little comment. Can you update to 1.6.1 cocoapods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.