Skip to content

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Mar 24, 2025

Summary

  • Update the flag's dependent holdoutIds

Test plan

  • New test cases added

Issues

  • FSSDK-11372
@muzahidul-opti muzahidul-opti marked this pull request as ready for review April 8, 2025 15:57
@muzahidul-opti muzahidul-opti changed the title [FSSDK-11372] assign holdouts to feature flags [FSSDK-11372] assign holdoutIds to feature flags Apr 8, 2025
@muzahidul-opti muzahidul-opti requested a review from jaeopt April 8, 2025 16:05
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's discuss options.

@muzahidul-opti muzahidul-opti requested a review from jaeopt April 9, 2025 18:24
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need to add order enforcement as discussed.

@muzahidul-opti muzahidul-opti requested a review from jaeopt April 15, 2025 14:53
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change. It looks like we need to fix ordering.

@muzahidul-opti
Copy link
Contributor Author

I like the change. It looks like we need to fix ordering.
done

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good! A few more clean up tips.

muzahidul-opti and others added 2 commits April 17, 2025 23:37
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
@muzahidul-opti muzahidul-opti requested a review from jaeopt April 18, 2025 15:17
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@muzahidul-opti muzahidul-opti merged commit 7c4fee7 into master Apr 21, 2025
19 of 22 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/FSSDK-11372 branch April 21, 2025 13:15
muzahidul-opti added a commit that referenced this pull request May 29, 2025
* master: Experiment id and variation id added into decision notification payload (#589) [FSSDK-11374] add test cases for impression event and decision listener with holdout support (#588) [FSSDK-11373] add holdout support and refactor decision logic in DefaultDecisionService (#587) [FSSDK-11372] assign holdoutIds to feature flags (#578) [FSSDK-11371] parsing holdout section from the datafile (#577) [FSSDK-11111] chore: update cocoapods version (#576) [FSSDK-11102] chore: replace travis-ci-tools repository (#571)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants