[FSSDK-9419]: feat: Swift async-await support added #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jaeopt requested changes Jun 20, 2023
Tests/OptimizelyTests-APIs/OptimizelyClientTests_Init_Async_Await.swift Outdated Show resolved Hide resolved
Tests/OptimizelyTests-APIs/OptimizelyClientTests_Init_Async_Await.swift Outdated Show resolved Hide resolved
Tests/OptimizelyTests-APIs/OptimizelyClientTests_Init_Async_Await.swift Outdated Show resolved Hide resolved
…ait.swift Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
muzahidul-opti changed the title muzahidul-opti changed the title jaeopt requested changes Jun 21, 2023
jaeopt requested changes Jun 22, 2023
DemoSwiftApp/AppDelegate.swift Outdated
Comment on lines 165 to 168
| // // For sample codes for APIs, see "Samples/SamplesForAPI.swift" | ||
| // //SamplesForAPI.checkOptimizelyConfig(optimizely: self.optimizely) | ||
| // //SamplesForAPI.checkOptimizelyUserContext(optimizely: self.optimizely) | ||
| // //SamplesForAPI.checkAudienceSegments(optimizely: self.optimizely) |
There was a problem hiding this comment.
Can we keep these lines? We use this for testing sample codes.
There was a problem hiding this comment.
Sure, will revert back.
| | ||
| guard let localDatafileUrl = Bundle.main.url(forResource: "demoTestDatafile", withExtension: "json"), | ||
| let localDatafile = try? Data(contentsOf: localDatafileUrl) | ||
| let localDatafile = try? Data(contentsOf: localDatafileUrl) |
There was a problem hiding this comment.
nit - extra spaces. swift lint?
There was a problem hiding this comment.
Don't see any lint warning.
| | ||
| if #available(iOS 13, *) { | ||
| if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *) { | ||
| Task { [user] in |
There was a problem hiding this comment.
Do we need this explicit capturing [user] here?
There was a problem hiding this comment.
Yah, as we declare user as local variable inside the static method, that's why we needed to capture it. Otherwise, the compiler throws errors. Normally we don't need to capture it, as we did in appdelegate.
| optimizely = OptimizelyClient(sdkKey: "<Your_SDK_Key>", | ||
| periodicDownloadInterval: 60) | ||
| if #available(iOS 13, *) { | ||
| Task { [optimizely] in |
There was a problem hiding this comment.
Do we need this explicit capturing [optimizely] here?
There was a problem hiding this comment.
Discussed above
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
russell-loube-optimizely changed the title muzahidul-opti changed the title muzahidul-opti changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Swift async-await support added for:
Test plan
Issues