Skip to content

[FSSDK-9433]: Adds support to override sdkName and sdkVersion for events #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2023
Merged

[FSSDK-9433]: Adds support to override sdkName and sdkVersion for events #512

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8bf59e2
Adds support to override clientName for events
yasirfolio3 Jun 16, 2023
4b73fc6
suggested changes made.
yasirfolio3 Jun 19, 2023
caf964c
cleanup
yasirfolio3 Jun 19, 2023
c0c0c17
Added suggested unit test
yasirfolio3 Jun 20, 2023
4b8867e
cleanup.
yasirfolio3 Jun 20, 2023
0f187f7
cleanup.
yasirfolio3 Jun 20, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup.
  • Loading branch information
@yasirfolio3
yasirfolio3 committed Jun 20, 2023
commit 4b8867e36adc20a55a9b16e5497ef5c75d28bd22
1 change: 0 additions & 1 deletion Tests/OptimizelyTests-APIs/OptimizelyClientTests_ODP.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ class OptimizelyClientTests_ODP: XCTestCase {

try? tmpOptimizely.sendOdpEvent(type: "t1", action: "a1", identifiers: ["k1": "v1"], data: ["k21": "v2", "k22": true, "k23": 3.5, "k24": nil])

// swift handles <nil> in Any type in a weird way. It's a nil but cannot be AssertNil. Use stringify to validate nil.
XCTAssertEqual(odpEventManager.receivedData["data_source_version"] as! String, "1234")
XCTAssertEqual(odpEventManager.receivedData["data_source"] as! String, "flutter-sdk")
}
Expand Down