Skip to content

[FSSDK-8554] add blocking version of fetchQualifiedSegments #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2023
Merged

[FSSDK-8554] add blocking version of fetchQualifiedSegments #489

merged 2 commits into from
Apr 21, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Apr 20, 2023

Summary

  • blocking version of fetchQualifiedSegments is added (convenient with asynchronous OptimizelyClient start)
  • clean up non-blocking version of fetchQualifiedSegments (remove segments in completion handler)

Test plan

  • add unit tests for blocking fetchQualifiedSegments

Issues
@jaeopt jaeopt requested a review from a team as a code owner April 20, 2023 23:07
yasirfolio3
yasirfolio3 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jaeopt jaeopt merged commit 7a52c97 into master Apr 21, 2023
@jaeopt jaeopt deleted the jae/odp-sync branch April 21, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jaeopt @yasirfolio3