fix data models: OPTAttribue, OPTVariable, OPTFeatureVariable #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
jaeopt commented Feb 7, 2019
jaeopt commented - change class to struct
- remove "public"
- touched other errors with temp fixes (compile errors for inconsistent access control), so we can move on to complete all data model conversion.
- {OPTExperiment, OPTVariation} for notification replaced with temp public data formats. We need to work on them later.
- added unit tests for models
thomaszurkan-optimizely suggested changes Feb 7, 2019
Contributor
thomaszurkan-optimizely left a comment
thomaszurkan-optimizely left a comment There was a problem hiding this comment.
Can we change the names for the structs you changed? Drop the OPT.
thomaszurkan-optimizely suggested changes Feb 12, 2019
Contributor
thomaszurkan-optimizely left a comment
thomaszurkan-optimizely left a comment There was a problem hiding this comment.
Let's remove both segmentId and group id off of feature flag.
thomaszurkan-optimizely approved these changes Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.