Skip to content

(fix):fix the remove last item #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

(fix):fix the remove last item #33

merged 1 commit into from
Jan 31, 2019

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Jan 31, 2019

found a bug where data store queue was saving to user defaults instead of data store.
jaeopt
jaeopt approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jaeopt jaeopt merged commit db7fcdd into master Jan 31, 2019
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fixDataStoreQueue branch May 25, 2019 00:20
@weedmapsmike weedmapsmike mentioned this pull request Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@thomaszurkan-optimizely @jaeopt