Forward resourceTimeout to datafileHandler #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| @ffittschen It' a good catch! Can you sign our CLA if you did not yet? |
Contributor
| This actually ends up breaking tests:
Could you please fix the compile error in there? |
Contributor Author
| Build should be green now. There are still some tests failing locally, but those same tests also fail on |
jaeopt pushed a commit that referenced this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
During evaluations of which
startmethod we should use in our project, we discovered that in the async initialization, theresourceTimeoutis not forwarded to thedatafileHandler. This will be fixed with this PR.