clean up DemoSwiftApp #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
thomaszurkan-optimizely suggested changes Apr 25, 2019
Contributor
thomaszurkan-optimizely left a comment
thomaszurkan-optimizely left a comment There was a problem hiding this comment.
Can we create a jira ticket to make sure that there is a example/demo app that still includes all the integrations if you want to remove them from here?
| #import "FailureViewController.h" | ||
| | ||
| @import Optimizely; | ||
| #if TARGET_OS_IOS |
Contributor
There was a problem hiding this comment.
Do you know why that is there?
| workspace 'OptimizelySDK.xcworkspace' | ||
| | ||
| | ||
| def analytics_pods |
Contributor
There was a problem hiding this comment.
So, a very important part of Optimizely SDKs is integration with other analytics software. The examples below are all showing how to integrate with these different providers. If you are going to remove this, I'd like to see the documentation updated so that all of this is still captured somewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.