Skip to content

ci: Checking FSC on Pr 217 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

ci: Checking FSC on Pr 217 #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dcb37e
Moves Project to its own conventional file
jasonkarns Oct 26, 2019
d32a9e0
Trim requires
jasonkarns Oct 26, 2019
458a699
Remove redundant namespace prefix
jasonkarns Oct 26, 2019
e90de35
Merge branch 'master' into conventional-file
msohailhussain Dec 3, 2019
1a0675d
auto generate a new rubocop todo file
oakbani Dec 4, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 34 additions & 47 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,34 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2017-12-06 17:48:00 +0500 using RuboCop version 0.51.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
Lint/HandleExceptions:
Exclude:
- 'Rakefile'

# Offense count: 1
Lint/LiteralAsCondition:
Exclude:
- 'lib/optimizely/config/datafile_project_config.rb'

# Offense count: 1
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
Max: 6
Exclude:
- 'lib/optimizely.rb'
- 'lib/optimizely/config_manager/http_project_config_manager.rb'
- 'lib/optimizely/event/batch_event_processor.rb'
- 'lib/optimizely/event/entity/conversion_event.rb'
- 'lib/optimizely/event/entity/event_context.rb'
- 'lib/optimizely/event/entity/impression_event.rb'
- 'lib/optimizely/event/entity/snapshot_event.rb'
- 'lib/optimizely/optimizely_factory.rb'

Naming/AccessorMethodName:
Exclude:
- 'lib/optimizely/config_manager/http_project_config_manager.rb'
- 'spec/optimizely_factory_spec.rb'

# Offense count: 1
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
# MethodDefinitionMacros: define_method, define_singleton_method
Naming/PredicateName:
Exclude:
- 'spec/**/*'
- 'lib/optimizely.rb'
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2019-12-04 10:26:47 +0500 using RuboCop version 0.73.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Configuration parameters: AllowComments.
Lint/HandleExceptions:
Exclude:
- 'Rakefile'

# Offense count: 8
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
Max: 12

# Offense count: 1
Naming/AccessorMethodName:
Exclude:
- 'lib/optimizely/config_manager/http_project_config_manager.rb'

# Offense count: 2
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
# MethodDefinitionMacros: define_method, define_singleton_method
Naming/PredicateName:
Exclude:
- 'spec/**/*'
- 'lib/optimizely/project.rb'
Loading