Skip to content

Conversation

aliabbasrizvi
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 2, 2019

Coverage Status

Coverage remained the same at 99.949% when pulling bf02ec0 on ali/prepare_for_release into 9d0de5f on master.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
Copy link
Contributor

There are linting errors in your file: https://travis-ci.org/optimizely/ruby-sdk/jobs/527555324 :)

@aliabbasrizvi aliabbasrizvi merged commit 486357d into master May 3, 2019
@aliabbasrizvi
Copy link
Contributor Author

Merging as tests pass in custom version

@aliabbasrizvi aliabbasrizvi deleted the ali/prepare_for_release branch May 3, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants