Skip to content

Send impression event when variation has feature disabled #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2018
Merged

Send impression event when variation has feature disabled #110

merged 4 commits into from
Jun 19, 2018

Conversation

mikeproeng37
Copy link
Contributor

No description provided.

@mikeproeng37
Copy link
Contributor Author

build
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 256a085 on ali/fix_event_sending_disabled_feature into c948863 on master.
aliabbasrizvi
aliabbasrizvi approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you take a look at the test and see if we can look at event content itself?
spec/project_spec.rb

it 'should return false, if the user is bucketed into a feature experiment but the featureEnabled property is false' do
it 'should return false and send impression if the user is bucketed into a feature experiment but the featureEnabled property is false' do
allow(project_instance.event_dispatcher).to receive(:dispatch_event).with(instance_of(Optimizely::Event))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we look at content of dispatch event itself?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try and it was giving me a lot of headache lol. The compat suite already checks the payload so I'd say we merge this in!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it.
@mikeproeng37 mikeproeng37 merged commit c4e1e0b into master Jun 19, 2018
@aliabbasrizvi aliabbasrizvi changed the title Ali/fix event sending disabled feature Send impression event when variation has feature disabled Jun 19, 2018
@mikeproeng37 mikeproeng37 deleted the ali/fix_event_sending_disabled_feature branch June 27, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@mikeproeng37 @coveralls @aliabbasrizvi