Skip to content

Conversation

@zashraf1985
Copy link
Contributor

Summary

Added Wrapper methods for decide APIS.

Test Plan

  • Manually Tested thouroughly.
  • Added unit tests.

Note: Even if the change looks ok and gets approved, its not mergable right now because it depends upon changes in the javascript SDK which are not final and released yet. This is why tests are also failing. They will pass once the corresponding javascript changes are merged and beta SDK is released.

@zashraf1985 zashraf1985 marked this pull request as ready for review January 8, 2021 03:00
@zashraf1985 zashraf1985 requested a review from mjc1283 January 8, 2021 03:00
@zashraf1985 zashraf1985 removed their assignment Jan 8, 2021
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985
Copy link
Contributor Author

Closing this because i did it in a cleaner way in
#98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants