Skip to content

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Oct 9, 2020

Summary

There were 23 security vulnerabilities in the dependencies. I brought them down to 3 medium risk ones. It appears to be difficult to bring it down to zero without forcing resolutions. I recommend to merge this PR first and then try fixing the remaining 3 later.

Before
image

After
image

Test Plan

All existing unit tests should pass

@zashraf1985 zashraf1985 removed their assignment Oct 12, 2020
@zashraf1985 zashraf1985 marked this pull request as ready for review October 12, 2020 17:58
@zashraf1985 zashraf1985 changed the title chore: Attempting to fixing vulnerable dependencies chore: Fixed Vulnerabilities in dependencies Oct 13, 2020
@mjc1283 mjc1283 merged commit b0f52b9 into master Oct 21, 2020
@mjc1283 mjc1283 deleted the zeeshan/testing-vulnerabilities branch October 21, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants