Junaed/fssdk 10980 optimizely onready always returns false #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Jest Coverage Report
Test suite run success266 tests passing in 10 suites. Report generated by 🧪jest coverage report action from 200da3a |
junaed-optimizely deleted the junaed/fssdk-10980-optimizely-onready-always-returns-false branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
optimizelyClient.isReadyalways returnsfalsewhen ODP is explicitly off and user id is null.Expected behavior - "User promise should not be fulfilled unless a valid user is set, when ODP is disabled".
Test plan
Test case has been added to cover this edge case
Issues