Skip to content

[FSSDK-10554] Can't set log level error #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

[FSSDK-10554] Can't set log level error #276

merged 1 commit into from
Aug 21, 2024

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Aug 20, 2024 •
edited
Loading

Summary

  • [BUG] Can't set log level #265 has been addressed.
  • Instead of creating a new log for the React client, we can reuse the global log that Optimizely already provides with its getLogger API. That way we can configure the log system as a whole from a single source.
  • FYI, we are already using getLogger for hooks and providers.

Test plan

Existing test should pass

Issues

FSSDK-10554
@junaed-optimizely junaed-optimizely marked this pull request as ready for review August 20, 2024 17:02
mikechu-optimizely
mikechu-optimizely approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@junaed-optimizely junaed-optimizely merged commit 9d08ac9 into master Aug 21, 2024
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10554-log-level-inconsistency branch August 21, 2024 11:21
@junaed-optimizely junaed-optimizely mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@junaed-optimizely @mikechu-optimizely