fix: updated datafile variable in README #223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikechu-optimizely requested changes Nov 3, 2023
There was a problem hiding this comment.
Hmmm 🤔 . I can't see what was changed. Maybe every line's EOL terminators were changed? They should be commited as lf I think.
Is there a way to give it another try?
There was a problem hiding this comment.
Oh I see: L92, L121, L182, & L460.
I feel the diff really should just show 4 changes.
This is open-source after all, we need to make sure all reading have a clear picture of the edits 😉
There was a problem hiding this comment.
Closing this & creating a new PR. EOL in gitattributes is set to LF, but the README is currently in CRLF, thus showing the entire file as changed. Maybe we could change this in a later PR
| A new PR has been created |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
The "why"
README doc was out of sync with Developer docs
Test plan
It is a documentation update, thus not needed
Issues
Note
I've changed only 4 lines of code in this PR. yet, GitHub shows the entire file change for some reason 🫣