[FSSDK-9471] [React] Fetch segments in onready #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rafinutshaw-optimizely requested review from jaeopt, mikechu-optimizely and zashraf1985 
mikechu-optimizely approved these changes Jul 5, 2023
jaeopt requested changes Jul 5, 2023
jaeopt requested changes Jul 6, 2023
| reason: 'TIMEOUT', | ||
| message: | ||
| 'failed to initialize onReady before timeout, either the datafile or user info was not set before the timeout', | ||
| 'failed to initialize onReady before timeout, either the datafile, user info or qualified segments was not set before the timeout', |
There was a problem hiding this comment.
I believe this timeout is covering datafile ready timeout, not covering "qualifed segments" failure. The original message makes more sense.
| return Promise.race([this.dataReadyPromise, timeoutPromise]).then(res => { | ||
| return Promise.race([this.dataReadyPromise, timeoutPromise]).then(async res => { | ||
| if (res.success) { | ||
| await this.fetchQualifiedSegments(config?.segmentOptions); |
There was a problem hiding this comment.
What if fetch fails with network error, timeout, etc? res should be updated accordingly?
| Closing this due to change in requirement. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues