Skip to content

[FSSDK-8941] [React] Enable ODP Functionality in React Context #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 19, 2023
Merged

[FSSDK-8941] [React] Enable ODP Functionality in React Context #199

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
01b90bc
Update package.json to use JS beta
mikechu-optimizely May 9, 2023
4707271
WIP: Update package.json to use JS beta methods
mikechu-optimizely May 9, 2023
03a3d5c
[FSSDK-8941] noop commit to link to Jira
mikechu-optimizely May 9, 2023
4996542
Add locations of new fetchQualifedSegments tests
May 15, 2023
1f468b5
Update unit tests
May 15, 2023
56dabbd
Stub unit tests
May 15, 2023
f99e28c
Set react-sdk beta version
May 15, 2023
65a195d
Remove fetchQualSegs in setUser & update tests
May 16, 2023
3999331
Update yarn.lock
May 16, 2023
b63463f
Merge branch 'master' into mike/fetch-qualified-segments
rafinutshaw-optimizely May 16, 2023
c8dfaba
Remove fetchQS tests w/i setUser
May 16, 2023
37ff010
WIP: Update fetchQualifiedSegments tests
rafinutshaw-optimizely May 16, 2023
2ee7d9c
Rollback premature version bump
May 17, 2023
df6a504
Update tests
rafinutshaw-optimizely May 18, 2023
a0f938b
Merge branch 'mike/fetch-qualified-segments' of github.com:optimizely…
rafinutshaw-optimizely May 18, 2023
d3bfe51
Fix format and test
rafinutshaw-optimizely May 18, 2023
c70076e
Update copyright
rafinutshaw-optimizely May 18, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove fetchQS tests w/i setUser
  • Loading branch information
Mike Chu committed May 16, 2023
commit c8dfaba9cdaab845b33fd2175a8e60c887ad0335
26 changes: 0 additions & 26 deletions src/client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,32 +1178,6 @@ describe('ReactSDKClient', () => {
expect(mockInnerClient.getAllFeatureVariables).toBeCalledWith('feat1', 'user2', { bar: 'baz' });
});
});

describe('fetchQualifedSegments', () => {
it('should never call fetchQualifiedSegments if user ID is not set', ()=> {

});

it('should never call fetchQualifiedSegments if Optimizely client is not set', () => {

});

it('should never call fetchQualifiedSegments if Optimizely User Context is not set', () => {

});

it('should return log an info when ODP not integrated', ()=> {

});

it('should return false if fetch fails', ()=>{

});

it('should return true if fetch successful', () => {

});
});
});

describe('fetchQualifedSegments', () => {
Expand Down