Added react yml and integeration test github action #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| if: ${{ github.event_name == 'pull_request' }} | ||
| run: | | ||
| echo "SDK_BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV | ||
| echo "TRAVIS_BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
remove from here.
msohailhussain suggested changes Apr 26, 2022
| if: ${{ github.event_name != 'pull_request' }} | ||
| run: | | ||
| echo "SDK_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV | ||
| echo "TRAVIS_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Suggested change
| echo "TRAVIS_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV |
.github/workflows/react.yml Outdated
| - run: yarn test | ||
| | ||
| integration_tests: | ||
| uses: optimizely/react-sdk/.github/workflows/integration_test.yml@mnoman/gitAction |
There was a problem hiding this comment.
Suggested change
| uses: optimizely/react-sdk/.github/workflows/integration_test.yml@mnoman/gitAction | |
| uses: optimizely/react-sdk/.github/workflows/integration_test.yml@master |
.github/workflows/react.yml Outdated
| TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }} | ||
| | ||
| publish: | ||
| if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
we need to add one more condition here.
tag =~ /^[0-9]+\.[0-9]+\.[0-9]+/ .github/workflows/react.yml Outdated
| hub version | ||
| - name: script | ||
| env: | ||
| travis_tag: ${GITHUB_REF#refs/*/} |
There was a problem hiding this comment.
This doesn't seem right, please check what comes in travis_tag, give a try and push tag to this branch but make sure to remove publishing script.
Co-authored-by: Mirza Sohail Hussain <mirza.sohailhussain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
NOTE:
Passed build link
Test plan
All tests should pass