Skip to content

Conversation

The-inside-man
Copy link
Contributor

@The-inside-man The-inside-man commented Sep 16, 2021

Summary

  • Deprecate experiments_map for OptimizelyFeature
  • Note added for experiments_map in OptimizelyConfig stating it is for legacy projects only

OptimizelyFeature experiments_map is deprecated, users shall use experiment_rules and delivery_rules.

Test plan

  • FSC

Issues

  • N/A
@coveralls
Copy link

coveralls commented Sep 16, 2021

Coverage Status

Coverage remained the same at 96.02% when pulling 3f0f9f1 on jbrown/deprecationV2 into de91292 on master.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the PR note. OptimizelyConfig experiments_map is not deprecated while that for OptimizelyFeature is. It's still valid for legacy projects. Other than that, LGTM

@The-inside-man The-inside-man merged commit 92174e0 into master Sep 16, 2021
@The-inside-man The-inside-man deleted the jbrown/deprecationV2 branch September 16, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants