- Notifications
You must be signed in to change notification settings - Fork 37
feat: add user context #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits Select commit Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
# Copyright 2020, Optimizely and contributors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
| ||
| ||
class UserContext(object): | ||
""" | ||
Representation of an Optimizely User Context using which APIs are to be called. | ||
""" | ||
| ||
def __init__(self, optimizely_client, user_id, user_attributes=None): | ||
""" Create an instance of the Optimizely User Context. | ||
| ||
Args: | ||
optimizely_client: client used when calling decisions for this user context | ||
user_id: user id of this user context | ||
user_attributes: user attributes to use for this user context | ||
| ||
Returns: | ||
UserContext instance | ||
""" | ||
| ||
self.client = optimizely_client | ||
self.user_id = user_id | ||
self.user_attributes = user_attributes.copy() if user_attributes else {} | ||
| ||
def set_attribute(self, attribute_key, attribute_value): | ||
""" | ||
sets a attribute by key for this user context. | ||
Args: | ||
attribute_key: key to use for attribute | ||
attribute_value: attribute value | ||
| ||
Returns: | ||
None | ||
""" | ||
self.user_attributes[attribute_key] = attribute_value | ||
| ||
def decide(self, key, options=None): | ||
""" | ||
TODO: call optimizely_clieint.decide | ||
Args: | ||
key: | ||
options: | ||
| ||
Returns: | ||
| ||
""" | ||
| ||
def decide_for_keys(self, keys, options=None): | ||
""" | ||
TODO: call optimizely_client.decide_for_keys | ||
Args: | ||
keys: | ||
options: | ||
| ||
Returns: | ||
| ||
""" | ||
| ||
def decide_all(self, options=None): | ||
""" | ||
TODO: call optimize_client.decide_all | ||
Args: | ||
options: | ||
| ||
Returns: | ||
| ||
""" | ||
| ||
def track_event(self, event_key, event_tags=None): | ||
self.optimizely_client.track(event_key, self.user_id, self.user_attributes, event_tags) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Copyright 2020, Optimizely | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
| ||
from . import base | ||
from optimizely import logger | ||
from optimizely.user_context import UserContext | ||
| ||
| ||
class UserContextTests(base.BaseTest): | ||
def setUp(self): | ||
base.BaseTest.setUp(self, 'config_dict_with_multiple_experiments') | ||
self.logger = logger.NoOpLogger() | ||
| ||
def test_user_context(self): | ||
""" | ||
tests user context creating and attributes | ||
""" | ||
uc = UserContext(self.optimizely, "test_user") | ||
self.assertEqual(uc.user_attributes, {}, "should have created default empty") | ||
self.assertEqual(uc.user_id, "test_user", "should have same user id") | ||
uc.set_attribute("key", "value") | ||
self.assertEqual(uc.user_attributes["key"], "value", "should have added attribute") | ||
uc.set_attribute("key", "value2") | ||
self.assertEqual(uc.user_attributes["key"], "value2", "should have new attribute") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we have more tests:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in 314 |
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a mutex control for attributes read/write?
"setAttributes" and attribute -reading for decide can happen in other threads. See C#-sdk as a good reference (optimizely/csharp-sdk#253)