Skip to content

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Sep 15, 2020

Summary

jsonschema 3.2.0 has a dependency to pyrsistent>=0.14.0. When PIP tries to install the latest pyrsistent version, it requires Python > 3.5. Therefore, in this PR we explicitly define the version for pyrsistent package.

Test plan

All checks continue to pass.

@coveralls
Copy link

coveralls commented Sep 16, 2020

Coverage Status

Coverage remained the same at 97.154% when pulling b5d0be2 on oakbani-patch-1 into 9a455f6 on master.

@oakbani oakbani changed the title TESTING BUILD on Travis build: Fix package installation for Python 3.4 and pypy Sep 16, 2020
@oakbani oakbani removed their assignment Sep 16, 2020
@oakbani oakbani marked this pull request as ready for review September 16, 2020 06:56
@oakbani oakbani requested a review from a team as a code owner September 16, 2020 06:56
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi merged commit 59fab33 into master Sep 16, 2020
@aliabbasrizvi aliabbasrizvi deleted the oakbani-patch-1 branch September 16, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants