fix: change datafile accessor feature to return a string representation of datafile #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
optimizely/project_config.py Outdated
| | ||
| config = json.loads(datafile) | ||
| self._datafile = datafile | ||
| self._datafile = str(datafile) |
There was a problem hiding this comment.
You will have to specify encoding here if I understand correctly. It should be utf-8.
Python 2 by default does ascii and Python 3 does utf-8.
aliabbasrizvi suggested changes Jul 9, 2020
Mat001 approved these changes Jul 9, 2020
optimizely/project_config.py Outdated
| | ||
| config = json.loads(datafile) | ||
| self._datafile = datafile | ||
| self._datafile = str(datafile) |
There was a problem hiding this comment.
This is per @mjc1283 's request. That's fine w me if we want to return a string. though SOhail prefers JSON, but Peter found a way to still return string and then convert it back to JSON in the FSC.
optimizely-codereview-bot added 🤖 4 hrs 🤖 8 hrs 🤖 12 hrs and removed 🤖 4 hrs 🤖 8 hrs labels 
mjc1283 approved these changes Jul 14, 2020
optimizely-codereview-bot added 🤖 16 hrs 🤖 20 hrs 🤖 24 hrs and removed 🤖 12 hrs 🤖 16 hrs 🤖 20 hrs labels 
…e array of the datafile
aliabbasrizvi force-pushed the peter/datafile-accessor-json branch from 495f8da to 6357c04 Compare aliabbasrizvi approved these changes Jul 21, 2020
| Reran FSC tests with datafile accessor flag and passed. Merging. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
stringtype instead of previousbytestypeTest Plan
Note
fullstack_prod_suitebecause thebytesdatafile was not iterable, so I changed it to return astring