feat(forced-decision): Forced decision API's implemented for user context Android only #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…cision and removeAllForcedDecision apis in android
| decide(sdkKey, decideKeys, decideOptions, result); | ||
| break; | ||
| } | ||
| case APIs.SET_FORCED_DECISION: { |
There was a problem hiding this comment.
please revise this whole thing. We should parse parameters in their respective functions.
Or i would say, create methods getFlagKey, getRuleKey etc... pass arguments in those methods. and then call these methods from their respective function.
There was a problem hiding this comment.
thanks, looks cleaner.
msohailhussain previously approved these changes Aug 1, 2022
| import com.optimizely.optimizely_flutter_sdk.helper_classes.ArgumentsParser; | ||
| | ||
| import static com.optimizely.optimizely_flutter_sdk.helper_classes.Constants.*; | ||
| import static com.optimizely.optimizely_flutter_sdk.helper_classes.Utils.convertKeysCamelCaseToSnakeCase; |
There was a problem hiding this comment.
I need to discuss this method offline, this may take longer time to convert into camel case.
| result.success(createResponse(false, ErrorMessage.USER_CONTEXT_NOT_FOUND)); | ||
| return; | ||
| } | ||
| List<String> decideKeys = argumentsParser.getDecideKeys(); |
There was a problem hiding this comment.
Shouldn't this be an array?
| Map<String, Object> listenerUnmodifiable = Collections.unmodifiableMap(listenerResponse); | ||
| OptimizelyFlutterSdkPlugin.channel.invokeMethod("callbackListener", listenerUnmodifiable); | ||
| } | ||
| } |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Add a set of new APIs for forced-decisions to OptimizelyUserContext:
Test plan