Skip to content

chore(api): update Changelog with getFeatureVariable method #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 8, 2019
Merged

chore(api): update Changelog with getFeatureVariable method #320

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20b89f5
update changelog to include getFV method
brandonhudavid Aug 6, 2019
c710779
update changelog to include getFV method
brandonhudavid Aug 6, 2019
5a29701
place getFeatureVariable under New Features
brandonhudavid Aug 6, 2019
fe7ade0
Merge branch 'brandon/getFV_log' of github.com:optimizely/javascript-…
brandonhudavid Aug 6, 2019
2a2cfec
remove getFeatureVariable above New Features
brandonhudavid Aug 6, 2019
02d188b
Merge branch 'master' into brandon/getFV_log
Aug 7, 2019
ead391d
Merge branch 'master' into brandon/getFV_log
Aug 8, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update changelog to include getFV method
  • Loading branch information
@brandonhudavid
brandonhudavid committed Aug 6, 2019
commit c7107799e39c4f3f545effa9f4acb6ac9500a333
3 changes: 3 additions & 0 deletions packages/optimizely-sdk/CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [Unreleased]
Changes that have landed but are not yet released.

- Added non-typed `getFeatureVariable` method ([#298](https://github.com/optimizely/javascript-sdk/pull/298)) as a more idiomatic approach to getting values of feature variables.
- Typed `getFeatureVariable` methods will still be available for use.

### New Features
- Updated the `close` method to return a `Promise` representing the process of closing the instance. When `close` is called, any events waiting to be sent as part of a batched event request will be immediately batched and sent to the event dispatcher.
- If any such requests were sent to the event dispatcher, `close` returns a `Promise` that fulfills after the event dispatcher calls the response callback for each request. Otherwise, `close` returns an immediately-fulfilled `Promise`.
Expand Down