Skip to content

fix: Fixed ODP Event type and Json Parser log levels #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022
Merged

fix: Fixed ODP Event type and Json Parser log levels #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-api/src/main/java/com/optimizely/ab/internal/JsonParserProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public static JsonParserProvider getDefaultParser() {
continue;
}

logger.info("using json parser: {}", parser.className);
logger.debug("using json parser: {}", parser.className);
return parser;
}

Expand Down
2 changes: 1 addition & 1 deletion core-api/src/main/java/com/optimizely/ab/odp/ODPEventManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void identifyUser(@Nullable String vuid, @Nullable String userId) {
if (userId != null) {
identifiers.put(ODPUserKey.FS_USER_ID.getKeyString(), userId);
}
ODPEvent event = new ODPEvent("fullstack", "client_initialized", identifiers, null);
ODPEvent event = new ODPEvent("fullstack", "identified", identifiers, null);
sendEvent(event);
}

Expand Down
2 changes: 1 addition & 1 deletion core-api/src/main/java/com/optimizely/ab/odp/parser/ResponseJsonParserFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public static ResponseJsonParser getParser() {
jsonParser = new JsonSimpleParser();
break;
}
logger.info("Using " + parserProvider.toString() + " parser");
logger.debug("Using " + parserProvider.toString() + " parser");
return jsonParser;
}
}
2 changes: 1 addition & 1 deletion core-api/src/test/java/com/optimizely/ab/odp/ODPEventManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public void prepareCorrectPayloadForIdentifyUser() throws InterruptedException {
for (int i = 0; i < events.length(); i++) {
JSONObject event = events.getJSONObject(i);
assertEquals("fullstack", event.getString("type"));
assertEquals("client_initialized", event.getString("action"));
assertEquals("identified", event.getString("action"));
assertEquals("the-vuid-" + i, event.getJSONObject("identifiers").getString("vuid"));
assertEquals("the-fs-user-id-" + i, event.getJSONObject("identifiers").getString("fs_user_id"));
assertEquals("sdk", event.getJSONObject("data").getString("data_source_type"));
Expand Down