Skip to content

fix: add Optimizely builder option for client-engine info #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2022
Merged

fix: add Optimizely builder option for client-engine info #466

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c5082e
add builder option for client-engine info
jaeopt Mar 9, 2022
0098c8e
fix spotbugs issues
jaeopt Mar 9, 2022
a854b08
check null client version
jaeopt Mar 14, 2022
2f93f8b
add tests for invalid client name and version
jaeopt Mar 14, 2022
6abfd63
add doc
jaeopt Mar 14, 2022
05ed197
Merge branch 'master' into jae/event-version
jaeopt Mar 14, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check null client version
  • Loading branch information
@jaeopt
jaeopt committed Mar 14, 2022
commit a854b08b9e228962b98b5f25c3ef11b8ad668f2d
6 changes: 5 additions & 1 deletion core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ public final class BuildVersionInfo {
private static String clientVersion = readVersionNumber();
Copy link
Contributor

@msohailhussain msohailhussain Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final?
Copy link
Contributor Author

@jaeopt jaeopt Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike the old VERSION, this private variable can be changed with Optimizely.Builder.

public static void setClientVersion(String version) {
clientVersion = version;
if (version == null || version.isEmpty()) {
logger.warn("ClientVersion cannot be empty, defaulting to the core java-sdk version.");
return;
}
clientVersion = version;
}

public static String getClientVersion() {
Expand Down